Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(relay): use oneshot's to track requested streams #4900

Merged
merged 2 commits into from
Nov 28, 2023
Merged

refactor(relay): use oneshot's to track requested streams #4900

merged 2 commits into from
Nov 28, 2023
+99 −125

Conversation

thomaseizinger
Copy link
Contributor

Description

This is much cleaner as it allows us to construct a single Future that expresses the entire outbound protocol from stream opening to finish.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

This was referenced Nov 20, 2023
Closed
Closed
mxinden
mxinden approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Especially with make_new_reservation and establish_new_circuit.

@mergify mergify bot merged commit 4d7a535 into master Nov 28, 2023
@mergify mergify bot deleted the refactor/relay-use-oneshot branch November 28, 2023 13:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden